keep active stats lock held #32763
Merged
keep active stats lock held #32763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32763 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 785 785
Lines 211686 211731 +45
=======================================
+ Hits 173614 173668 +54
+ Misses 38072 38063 -9 |
|
Should the |
yeah, these were cherry picked from master so I could run diagnostics and test these changes out when master was broken recently against mnb. That is fixed now. Rebasing to master got rid of those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
let _ = ...causes rhs to be dropped immediately.So, active period was 0s.
Summary of Changes
use
let _guard = ...Fixes #